Awattar: fetch more than 24h price data #16338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andig
reviewed
Sep 26, 2024
| @@ -62,8 +62,14 @@ func (t *Awattar) run(done chan error) { | |||
| for ; true; <-tick.C { | |||
| var res awattar.Prices | |||
|
|
|||
| // Awattar publishes prices for next day around 13:00 CET/CEST, so up to 35h of price data are available | |||
| // To be on the safe side request a window of -2h and +48h, the API doesn't mind requesting more than available | |||
There was a problem hiding this comment.
Should we round to hours and do we really need two hours back instead of start of current hour?
There was a problem hiding this comment.
Not sure if we need 2 hours, but it could mitigate potential edge cases, like some potential errors in the awattar api regarding daylight savings time. Requesting one entry less doesn't seem worth investigating potential edge cases.
Start time in the Awattar api is exclusive, requesting start=12:15 for example returns 13:00-14:00 as the first entry in the response.
Rounding would be possible, but I don't see the benefit, except of adding complexity.
The PR is open for your changes.
andig
reviewed
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the Awattar API call is unparametrized, which fetches the price for the next 24 hours.
Awattar publishes the prices for the next day around noon, so up to 35 hours of price data can be availible. The Awattar API also supports fetching more than 24 hours by parametrizing the API call with
startandendtimestamps.This change makes all future price data available to evcc. This is important if you plan a charge to finish on the next day in the evening.
before:
after:
